Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8951 )
Change subject: KUDU-2251: rowset size can overflow int in RowSetInfo ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8951/5/src/kudu/integration-tests/CMakeLists.txt File src/kudu/integration-tests/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/8951/5/src/kudu/integration-tests/CMakeLists.txt@77 PS5, Line 77: ADD_KUDU_TEST(heavy-update-compaction-test RUN_SERIAL true) nit: can we name this '-itest' since it's an integration level test? http://gerrit.cloudera.org:8080/#/c/8951/5/src/kudu/integration-tests/heavy-update-compaction-test.cc File src/kudu/integration-tests/heavy-update-compaction-test.cc: http://gerrit.cloudera.org:8080/#/c/8951/5/src/kudu/integration-tests/heavy-update-compaction-test.cc@139 PS5, Line 139: const char* const kTableName = "heavy-update-compaction-test"; style strikes me as a bit odd to have the constant interspersed with functions -- To view, visit http://gerrit.cloudera.org:8080/8951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74975cdab605b51617d93d1ae98ef72ce87e35cb Gerrit-Change-Number: 8951 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 06 Jan 2018 02:44:09 +0000 Gerrit-HasComments: Yes
