David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8951 )
Change subject: KUDU-2251: rowset size can overflow int in RowSetInfo ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/8951/6/src/kudu/integration-tests/heavy-update-compaction-itest.cc File src/kudu/integration-tests/heavy-update-compaction-itest.cc: http://gerrit.cloudera.org:8080/#/c/8951/6/src/kudu/integration-tests/heavy-update-compaction-itest.cc@206 PS6, Line 206: // Scan the updated rows and ensure the final values are present. : KuduScanner scanner(table_.get()); : ASSERT_OK(scanner.SetFaultTolerant()); : ASSERT_OK(scanner.AddConjunctPredicate( : table_->NewComparisonPredicate( : "key", KuduPredicate::LESS, KuduValue::FromInt(FLAGS_rows)))); : : // Walking the updates can take a long time. : scanner.SetTimeoutMillis(120 * 1000); : : LOG_TIMING(INFO, "scanning") { : ASSERT_OK(scanner.Open()); : vector<KuduRowResult> rows; : size_t final_values_offset = 0; : while (scanner.HasMoreRows()) { : ASSERT_OK(scanner.NextBatch(&rows)); : for (const auto & row : rows) { : for (int idx = 1; idx <= 5; idx++) { : ASSERT_GT(final_values.size(), final_values_offset); : Slice actual_val; : ASSERT_OK(row.GetString(idx, &actual_val)); : EXPECT_EQ(actual_val, final_values[final_values_offset++]); : } : } : } : } Thanks for doing this. I'm surprised that it might take so long. I guess this is one of the cases where skipping updates is going to make a huge difference. http://gerrit.cloudera.org:8080/#/c/8951/6/src/kudu/tablet/rowset_info.h File src/kudu/tablet/rowset_info.h: http://gerrit.cloudera.org:8080/#/c/8951/6/src/kudu/tablet/rowset_info.h@21 PS6, Line 21: extra line -- To view, visit http://gerrit.cloudera.org:8080/8951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74975cdab605b51617d93d1ae98ef72ce87e35cb Gerrit-Change-Number: 8951 Gerrit-PatchSet: 6 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 08 Jan 2018 19:02:48 +0000 Gerrit-HasComments: Yes
