Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )
Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > One thought I had about this: do we need to also do something to ensure that, > if the Spark driver has connected to the cluster, but the token is expired, > that it proactively re-connects to get a new token to propagate to the > executors? Prior to KUDU-2259 landing it doesn't appear that we explicitly handled this, unless I'm missing something. In addition, I believe exportAuthenticationCredentials is only called once in the life of a Kudu/Spark job, when the KuduContext is being constructed (it's cached as a serializable val). http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java: http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@175 PS1, Line 175: startCluster(ImmutableSet.of(Option.SHORT_TOKENS_AND_TICKETS, Are these options necessary? -- To view, visit http://gerrit.cloudera.org:8080/9814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72 Gerrit-Change-Number: 9814 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 18:28:05 +0000 Gerrit-HasComments: Yes
