Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )
Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@310 PS1, Line 310: * Set to true once we have connected to a master at least once. > Can we specify here this is for indicating whether to export authn? Done http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java: http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@175 PS1, Line 175: startCluster(ImmutableSet.of(Option.SHORT_TOKENS_AND_TICKETS, > Are these options necessary? Yea the test fails without the fix. The options arent necessary, removed them. -- To view, visit http://gerrit.cloudera.org:8080/9814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72 Gerrit-Change-Number: 9814 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 20:52:49 +0000 Gerrit-HasComments: Yes
