Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )
Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster ...................................................................... Patch Set 2: > Patch Set 2: Code-Review+1 > > lgtm, but I think we should check if AuthnToken is empty before assign it at > https://github.com/apache/kudu/blob/master/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java#L313. > Otherwise a default value is used. Sorry that I should catch this in the > previous review cycle. good catch, this should improve the error messages. Done. -- To view, visit http://gerrit.cloudera.org:8080/9814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72 Gerrit-Change-Number: 9814 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 21:54:16 +0000 Gerrit-HasComments: No
