Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9899 )
Change subject: Various fixes for clang-tidy errors ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/cfile/index-test.cc File src/kudu/cfile/index-test.cc: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/cfile/index-test.cc@43 PS2, Line 43: const std::string &search_key, Nit: const std::string& Or were you trying to be consistent with the style of the other args? http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition.cc@119 PS2, Line 119: for (const PartitionSchemaPB_ColumnIdentifierPB& identifier : identifiers) { Could use const auto here too. http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition_pruner.cc@163 PS2, Line 163: for (const ColumnId& column : range_columns) { Could use const auto http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/rowset_info.cc File src/kudu/tablet/rowset_info.cc: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/rowset_info.cc@207 PS2, Line 207: for (const shared_ptr<RowSet>& rs : tree.all_rowsets()) { Could use const auto http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/transactions/transaction_tracker.cc File src/kudu/tablet/transactions/transaction_tracker.cc: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/transactions/transaction_tracker.cc@230 PS2, Line 230: for (const scoped_refptr<TransactionDriver>& driver : txns) { Const auto? -- To view, visit http://gerrit.cloudera.org:8080/9899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342 Gerrit-Change-Number: 9899 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 18 Apr 2018 19:52:31 +0000 Gerrit-HasComments: Yes
