Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9899 )
Change subject: Various fixes for clang-tidy errors ...................................................................... Patch Set 3: (12 comments) http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/cfile/index-test.cc File src/kudu/cfile/index-test.cc: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/cfile/index-test.cc@43 PS2, Line 43: const std::string &search_key, > Nit: const std::string& yea, the latter -- consistency within a declaration seemed better than following the new guide http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/client/meta_cache.h@141 PS2, Line 141: RemoteTablet* tablet); > warning: parameter 'tablet' is const-qualified in the function declaration; Done http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/client/schema.h@258 PS2, Line 258: const void* default_value = NULL, //NOLINT(modernize-use-nullptr) > warning: use nullptr [modernize-use-nullptr] Done http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition.cc@119 PS2, Line 119: for (const auto& identifier : identifiers) { > Could use const auto here too. Done http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition_pruner.cc@163 PS2, Line 163: for (const auto& column : range_columns) { > Could use const auto Done http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/schema.h@70 PS2, Line 70: explicit ColumnId(int32_t t) : t_(t) {} > warning: invalid case style for parameter 't_' [readability-identifier-nami Done http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/schema.h@72 PS2, Line 72: ColumnId(const ColumnId& o) = default; > warning: invalid case style for parameter 't_' [readability-identifier-nami Done http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/schema.h@76 PS2, Line 76: operator const int32_t() const { return t_; } // NOLINT > warning: 'operator const int' must be marked explicit to avoid unintentiona Done http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/rowset_info.cc File src/kudu/tablet/rowset_info.cc: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/rowset_info.cc@207 PS2, Line 207: if (rs->IsAvailableForCompaction()) { > Could use const auto Done http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/transactions/transaction_tracker.cc File src/kudu/tablet/transactions/transaction_tracker.cc: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/transactions/transaction_tracker.cc@230 PS2, Line 230: for (const auto& driver : txns) { > Const auto? Done http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/util/net/dns_resolver.cc File src/kudu/util/net/dns_resolver.cc: http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/util/net/dns_resolver.cc@50 PS2, Line 50: void DoResolution(const HostPort &hostport, vector<Sockaddr>* addresses, > warning: 'DoResolution' is a static definition in anonymous namespace; stat Done http://gerrit.cloudera.org:8080/#/c/9899/3/src/kudu/util/net/dns_resolver.cc File src/kudu/util/net/dns_resolver.cc: http://gerrit.cloudera.org:8080/#/c/9899/3/src/kudu/util/net/dns_resolver.cc@51 PS3, Line 51: const StatusCallback& cb) { > Nit: indentation Done -- To view, visit http://gerrit.cloudera.org:8080/9899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342 Gerrit-Change-Number: 9899 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 23 Apr 2018 20:00:21 +0000 Gerrit-HasComments: Yes
