Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9899
to look at the new patch set (#3).
Change subject: Various fixes for clang-tidy errors
......................................................................
Various fixes for clang-tidy errors
This updates the clang-tidy config to enable a few new checks and rename a few
old ones which were renamed in clang. I also ran through a bunch of checks
and fixed them using the following command:
find ../../src/kudu/ -name \*.cc | \
grep -v -- -test | \
grep -v gutil | \
xargs -P80 -I{} -n1 ../../thirdparty/clang-toolchain/bin/clang-tidy \
-checks=-readability*,-llvm-include-order,-modernize-use-nullptr,-google-readability-*,-misc-unused-*,-performance-inefficient-vector-operation
\
-p . --extra-arg=-DCLANG_TIDY -quiet {}
The above generated mostly straight-forward issues.
Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
---
M src/kudu/.clang-tidy
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/index-test.cc
M src/kudu/client/client.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/codegen/row_projector.cc
M src/kudu/codegen/row_projector.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/partial_row-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/schema.h
M src/kudu/common/types.h
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_cache.h
M src/kudu/consensus/peer_manager.cc
M src/kudu/consensus/peer_manager.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/experiments/merge-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/gutil/port.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/sys_catalog.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/periodic.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/remote_method.cc
M src/kudu/rpc/remote_method.h
M src/kudu/rpc/result_tracker.cc
M src/kudu/rpc/result_tracker.h
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/transfer.cc
M src/kudu/security/cert.cc
M src/kudu/tablet/compaction_policy.cc
M src/kudu/tablet/delta_stats.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/tablet/tablet-harness.h
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_bootstrap.h
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/tablet/transactions/transaction_tracker.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_copy_source_session.h
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/easy_json.cc
M src/kudu/util/easy_json.h
M src/kudu/util/hdr_histogram.cc
M src/kudu/util/hexdump.cc
M src/kudu/util/inline_slice.h
M src/kudu/util/mem_tracker.cc
M src/kudu/util/mem_tracker.h
M src/kudu/util/metrics.cc
M src/kudu/util/net/dns_resolver.cc
M src/kudu/util/net/socket.cc
M src/kudu/util/net/socket.h
M src/kudu/util/pb_util.cc
M src/kudu/util/status-test.cc
95 files changed, 345 insertions(+), 315 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/9899/3
--
To view, visit http://gerrit.cloudera.org:8080/9899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
