Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10161 )
Change subject: iwyu: add proper dependency on thrift generated code, check for iwyu errors ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10161/1/build-support/iwyu.py File build-support/iwyu.py: http://gerrit.cloudera.org:8080/#/c/10161/1/build-support/iwyu.py@52 PS1, Line 52: r'^.+?:\d+:\d+: (fatal )?error:' In $IWYU_SRC_ROOT/iwyu_test_util.py there is pattern for expected error/warning/diag output: _ACTUAL_DIAGNOSTICS_RE = re.compile(r'^(.*?):(\d+):\d+:\s*' r'(?:warning|error|fatal error):\s*(.*)$') Maybe, allow any number of spaces before '(fatal )?error' as well? Also, it seems IWYU itself can output messages like 'FATAL ERROR: ...' in case of wrong usage, etc.. Do we need to catch those here as well? -- To view, visit http://gerrit.cloudera.org:8080/10161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie44f25ebc160c587eb11b4b4730095ee1e6c4fde Gerrit-Change-Number: 10161 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 24 Apr 2018 03:01:57 +0000 Gerrit-HasComments: Yes
