Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10161 )
Change subject: iwyu: add proper dependency on thrift generated code, check for iwyu errors ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10161/1/build-support/iwyu.py File build-support/iwyu.py: http://gerrit.cloudera.org:8080/#/c/10161/1/build-support/iwyu.py@52 PS1, Line 52: r'^.+?:\d+:\d+: (fatal )?error:' > In $IWYU_SRC_ROOT/iwyu_test_util.py there is pattern for expected error/war the FATAL_ERROR case is already handled explicitly in _run_iwyu_tool. I added the \s* instead of ' ' -- To view, visit http://gerrit.cloudera.org:8080/10161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie44f25ebc160c587eb11b4b4730095ee1e6c4fde Gerrit-Change-Number: 10161 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 24 Apr 2018 18:03:28 +0000 Gerrit-HasComments: Yes
