Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10161
to look at the new patch set (#2).
Change subject: iwyu: add proper dependency on thrift generated code, check for
iwyu errors
......................................................................
iwyu: add proper dependency on thrift generated code, check for iwyu errors
IWYU was giving incorrect results on the HMS modules when running on
Jenkins. This was due to the 'iwyu' CMake target not depending on the
thrift code generation. IWYU was continuing to run despite having
'missing include' errors.
This patch adds the appropriate CMake dependency and also makes our
IWYU wrapper check for such errors in the IWYU output.
I also changed the IWYU wrapper to explicitly build the IWYU
dependencies before running so that even if a user invokes it directly,
they won't hit this issue.
Change-Id: Ie44f25ebc160c587eb11b4b4730095ee1e6c4fde
---
M CMakeLists.txt
M build-support/iwyu.py
2 files changed, 19 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/10161/2
--
To view, visit http://gerrit.cloudera.org:8080/10161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie44f25ebc160c587eb11b4b4730095ee1e6c4fde
Gerrit-Change-Number: 10161
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
