Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 )
Change subject: java: enable error-prone for java builds ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4425/4/java/gradle/quality.gradle File java/gradle/quality.gradle: http://gerrit.cloudera.org:8080/#/c/4425/4/java/gradle/quality.gradle@76 PS4, Line 76: signature 'org.codehaus.mojo.signature:java17:1.0@signature' > I am not a fan that this needs to run all the time when compiling as oppose that's sort of the design of error-prone. It's actually a subclass of the Java compiler that hooks into the compilation process itself, rather than doing post-compilation bytecode analysis. I suppose it could be an optional flag, but I kind of like that it will break your compile for certain classes of errors -- To view, visit http://gerrit.cloudera.org:8080/4425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebafbb307904875490426dd699ab1f55e21d284d Gerrit-Change-Number: 4425 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 25 Apr 2018 22:29:01 +0000 Gerrit-HasComments: Yes
