Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 )
Change subject: java: enable error-prone for java builds ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4425/4/java/gradle/quality.gradle File java/gradle/quality.gradle: http://gerrit.cloudera.org:8080/#/c/4425/4/java/gradle/quality.gradle@76 PS4, Line 76: tasks.withType(JavaCompile) { > that's sort of the design of error-prone. It's actually a subclass of the J I like to have all the levers for control at the task level and often we use certain tasks for "testing" vs "packaging". My concern is if the static code analysis complicates or breaks longer running, assembly only, packaging type jobs. For those we tend to use `gradle assemble` instead of `gradle check` or `gradle build`. If it does't break things, it likely makes the build longer. -- To view, visit http://gerrit.cloudera.org:8080/4425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebafbb307904875490426dd699ab1f55e21d284d Gerrit-Change-Number: 4425 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 01:19:48 +0000 Gerrit-HasComments: Yes
