Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 )
Change subject: java: enable error-prone for java builds ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4425/4/java/gradle/quality.gradle File java/gradle/quality.gradle: http://gerrit.cloudera.org:8080/#/c/4425/4/java/gradle/quality.gradle@76 PS4, Line 76: tasks.withType(JavaCompile) { > I like to have all the levers for control at the task level and often we us Yea, that's why I think it's important to pin a specific version as I did here, so we don't have previously-working builds spontaneously break. FWIW, Google uses error-prone by default instead of javac for all of their builds, so there's at least some evidence that it's stable and usable as a general purpose replacement. Open source bazel also does this -- java targets always use error-prone for javac. Not sure about the build time overhead. It seemed to not be much slower as far as I could notice. -- To view, visit http://gerrit.cloudera.org:8080/4425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebafbb307904875490426dd699ab1f55e21d284d Gerrit-Change-Number: 4425 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 17:42:34 +0000 Gerrit-HasComments: Yes
