Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 )
Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc File src/kudu/util/curl_util.cc: http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc@96 PS7, Line 96: CHECK_NOTNULL(curl_headers); > By choke I mean would curl_slist_append(ch, s) crash/SIGSEGV if ch is a nul Oh I see. It seems fine? It's based on the example I followed: https://curl.haxx.se/libcurl/c/httpcustomheader.html -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 7 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 16 May 2018 16:09:28 +0000 Gerrit-HasComments: Yes