Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 )
Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths ...................................................................... Patch Set 9: (1 comment) Almost there: just one more nit. http://gerrit.cloudera.org:8080/#/c/10332/9/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/10332/9/src/kudu/server/webserver.cc@490 PS9, Line 490: if (zlib::Compress(Slice(full_content), &oss).ok()) { : full_content = oss.str(); : is_compressed = true; : } else { : LOG(WARNING) << "Could not compress output"; : } nit: it might be useful to output information from the error, e.g. Status s = zlib::Compress(...); if (s.ok()) { ... } else { LOG(WARNING) << "could not compress output: " << s.ToString(); } -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 9 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 16 May 2018 22:00:42 +0000 Gerrit-HasComments: Yes
