Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 )
Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths ...................................................................... Patch Set 8: (2 comments) A couple of nits http://gerrit.cloudera.org:8080/#/c/10332/8/src/kudu/integration-tests/linked_list-test-util.h File src/kudu/integration-tests/linked_list-test-util.h: http://gerrit.cloudera.org:8080/#/c/10332/8/src/kudu/integration-tests/linked_list-test-util.h@379 PS8, Line 379: Status s; : // Switch compression back and forth. : s = compression_enabled nit: why not to combine declaration with initialization here? Status s = ... http://gerrit.cloudera.org:8080/#/c/10332/8/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/10332/8/src/kudu/server/webserver.cc@490 PS8, Line 490: zlib::Compress(Slice(full_content), &oss); What if it returns non-OK status? Maybe, then do LOG(WARNING) and return at this point (like it's done at line 444)? -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 8 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 16 May 2018 18:48:16 +0000 Gerrit-HasComments: Yes
