Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10428 )
Change subject: KUDU-2427: adjust gold linker detection ...................................................................... Patch Set 3: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLists.txt@442 PS3, Line 442: extract extracts http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLists.txt@442 PS3, Line 442: to drop http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLists.txt@510 PS3, Line 510: Error: Nit: does it add more clarity for the message? I saw another error message above, and it does not contain extra suffix like this. Maybe, for more consistency, add this suffix for the message at like 463 or drop it here. -- To view, visit http://gerrit.cloudera.org:8080/10428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1fae9893aaaf4916205d4c5ae6bb5c93e0505d0 Gerrit-Change-Number: 10428 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 17 May 2018 17:32:11 +0000 Gerrit-HasComments: Yes
