Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10428 )
Change subject: KUDU-2427: adjust gold linker detection ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLists.txt@479 PS3, Line 479: typically > really? I always use enable_devtoolset.sh on RHEL6 via some custom aliases, Nope. Technically you only need to run cmake within devtoolset-3; make and ninja needn't use it. See https://kudu.apache.org/docs/installation.html#rhel_from_source for more details. If make/ninja were also invoked inside devtoolset, this wouldn't be necessary. But I didn't feel comfortable requiring that workflow change, hence the workaround. http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLists.txt@484 PS3, Line 484: devtoolset-3 > if we must do this, maybe use string MATCHES regex Yeah I'll follow Todd's suggestion and use a prefix match via if(MATCHES). -- To view, visit http://gerrit.cloudera.org:8080/10428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1fae9893aaaf4916205d4c5ae6bb5c93e0505d0 Gerrit-Change-Number: 10428 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 17 May 2018 21:59:06 +0000 Gerrit-HasComments: Yes
