Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10428 )
Change subject: KUDU-2427: adjust gold linker detection ...................................................................... Patch Set 3: Code-Review+1 (2 comments) looks good although I'm not sure skipping gold on el6 is necessary http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLists.txt@479 PS3, Line 479: typically really? I always use enable_devtoolset.sh on RHEL6 via some custom aliases, but I thought that was required, i.e. enable_devtoolset.sh ninja http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLists.txt@484 PS3, Line 484: devtoolset-3 > It would be true for all of them. Should I make this a prefix match? if we must do this, maybe use string MATCHES regex -- To view, visit http://gerrit.cloudera.org:8080/10428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1fae9893aaaf4916205d4c5ae6bb5c93e0505d0 Gerrit-Change-Number: 10428 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 17 May 2018 20:58:39 +0000 Gerrit-HasComments: Yes
