Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/10698 )
Change subject: [tools] Add simple util for version parsing
......................................................................
Patch Set 1:
> > Do you think util/version_util.{cc,h} would be a better home for this?
>
> I intended it to apply only to tools and not more generally. Do you really
> want it there?
I don't see anything tools-specific about the patch though; you've defined a
version as x.y.z-extra, which is exactly what
VersionInfo::GetShortVersionInfo() will return. So the fit seems pretty clear
to me.
--
To view, visit http://gerrit.cloudera.org:8080/10698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcf3b10b699e89ad489144611990702dec8af19
Gerrit-Change-Number: 10698
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Tue, 12 Jun 2018 22:51:35 +0000
Gerrit-HasComments: No
