Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10698 )
Change subject: [tools] Add simple util for version parsing ...................................................................... Patch Set 3: Code-Review+1 (1 comment) overall lgtm modulo Adar's comments and the friend question http://gerrit.cloudera.org:8080/#/c/10698/3/src/kudu/util/version_util.h File src/kudu/util/version_util.h: http://gerrit.cloudera.org:8080/#/c/10698/3/src/kudu/util/version_util.h@39 PS3, Line 39: friend why friend? -- To view, visit http://gerrit.cloudera.org:8080/10698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bcf3b10b699e89ad489144611990702dec8af19 Gerrit-Change-Number: 10698 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 14 Jun 2018 07:01:18 +0000 Gerrit-HasComments: Yes
