Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10698 )
Change subject: [tools] Add simple util for version parsing ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/10698/3/src/kudu/util/version_util.h File src/kudu/util/version_util.h: http://gerrit.cloudera.org:8080/#/c/10698/3/src/kudu/util/version_util.h@39 PS3, Line 39: friend > why friend? It's necessary to declare the overload in the Version struct. But it can also be declared as a function outside. http://gerrit.cloudera.org:8080/#/c/10698/3/src/kudu/util/version_util.h@53 PS3, Line 53: // Parse 'version_str' into 'tvi'. 'tvi' must not be null. > Not 'tvi' anymore. Done http://gerrit.cloudera.org:8080/#/c/10698/3/src/kudu/util/version_util.cc File src/kudu/util/version_util.cc: http://gerrit.cloudera.org:8080/#/c/10698/3/src/kudu/util/version_util.cc@55 PS3, Line 55: Status ParseVersion(const std::string& version_str, > Don't need std:: prefix. Done -- To view, visit http://gerrit.cloudera.org:8080/10698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bcf3b10b699e89ad489144611990702dec8af19 Gerrit-Change-Number: 10698 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 14 Jun 2018 17:19:54 +0000 Gerrit-HasComments: Yes
