Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11040 )
Change subject: hms precheck tool ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/11040/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11040/2//COMMIT_MSG@11 PS2, Line 11: issues Can you add a bit explanation of what kind of issue they are? http://gerrit.cloudera.org:8080/#/c/11040/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11040/3/src/kudu/tools/kudu-tool-test.cc@2639 PS3, Line 2639: A.B 'A.B!' ? http://gerrit.cloudera.org:8080/#/c/11040/3/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/11040/3/src/kudu/tools/tool_action_hms.cc@685 PS3, Line 685: This is not a Hive-compatible table name, so there can't be a conflict : // among normalized names. Sorry that I am not sure if I follow why conflicting names with hive-incompatible is not a concern? http://gerrit.cloudera.org:8080/#/c/11040/3/src/kudu/tools/tool_action_hms.cc@695 PS3, Line 695: conflicting table names It might be more clear if print out in the following format: normalized_table_name conflicting_table_name http://gerrit.cloudera.org:8080/#/c/11040/3/src/kudu/tools/tool_action_hms.cc@754 PS3, Line 754: .AddAction(std::move(hms_downgrade)) nit: Is this alphabetical ordered? -- To view, visit http://gerrit.cloudera.org:8080/11040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b23cb802b6434eba7e38443d3361ef70e6543e Gerrit-Change-Number: 11040 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 26 Jul 2018 00:49:03 +0000 Gerrit-HasComments: Yes
