Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11040 )

Change subject: hms precheck tool
......................................................................


Patch Set 9:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/11040/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11040/7//COMMIT_MSG@11
PS7, Line 11: are not unique when compared with Hive's
            : case-insensitive identifier rules
> Are there any other funny cases like already existing Kuud tables named lik
Not sure I fully understand your question.  It's definitely possible to have a 
table named 'default.MegaTable' in a cluster and then go through the workflow 
for enabling the HMS integration.  In that case the precheck tool would not 
flag the table (unless a second table conflicted with it by case such as 
'default.MEGATABLE').  The 'hms fix' tool will automatically create an HMS 
table for it when run.


http://gerrit.cloudera.org:8080/#/c/11040/7/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/11040/7/src/kudu/tools/kudu-tool-test.cc@2605
PS7, Line 2605:   for (const string& table_name : {
              :       "a.b",
              :       "foo.bar",
              :       "FOO.bar",
> I don't think this is relevant if using CreateKuduTable()
Done


http://gerrit.cloudera.org:8080/#/c/11040/7/src/kudu/tools/kudu-tool-test.cc@2626
PS7, Line 2626: ASSERT_STR_CONTAINS(o
> Maybe, it's worth asserting on specific type of error (RunTimeError, etc.)?
That depends on the internals of Subprocess::Call, which isn't really relevant 
here, and doesn't appear to be documented (not sure if that's intentional or 
not).


http://gerrit.cloudera.org:8080/#/c/11040/7/src/kudu/tools/kudu-tool-test.cc@2642
PS7, Line 2642: NO_FATALS(RunAction
> wrap into NO_FATALS()
Done


http://gerrit.cloudera.org:8080/#/c/11040/7/src/kudu/tools/kudu-tool-test.cc@2643
PS7, Line 2643:
> ditto
Done


http://gerrit.cloudera.org:8080/#/c/11040/7/src/kudu/tools/kudu-tool-test.cc@2646
PS7, Line 2646: cluster_->EnableMet
> ditto
Done


http://gerrit.cloudera.org:8080/#/c/11040/7/src/kudu/tools/kudu-tool-test.cc@2657
PS7, Line 2657:
              :       "foo.bar",
              :       "foo.bar2",
              :       "foo.bar3",
              :       "fuzz",
              :   }), tables);
              : }
              :
              : // This test is parameterized on the serialization mode and 
Kerberos.
              : cla
> nit: the expected value comes first -- that way it's easier to read the err
Done



--
To view, visit http://gerrit.cloudera.org:8080/11040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b23cb802b6434eba7e38443d3361ef70e6543e
Gerrit-Change-Number: 11040
Gerrit-PatchSet: 9
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 31 Jul 2018 00:10:14 +0000
Gerrit-HasComments: Yes

Reply via email to