Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11040 )
Change subject: hms precheck tool ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11040/3/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/11040/3/src/kudu/tools/tool_action_hms.cc@695 PS3, Line 695: > I see your point, the reason I was a bit concern about this is I am not sur Yeah I thought about that too, but I don't think listing the normalized table name will necessarily help in all cases, for instance the table names 'FOO' and 'FoO' the shared normalized name will be distinct from both. -- To view, visit http://gerrit.cloudera.org:8080/11040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b23cb802b6434eba7e38443d3361ef70e6543e Gerrit-Change-Number: 11040 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 27 Jul 2018 20:55:50 +0000 Gerrit-HasComments: Yes