Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11146 )
Change subject: python: copy pandas dependency into requirements.txt ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11146/1/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/11146/1/python/setup.py@193 PS1, Line 193: Note: dependencies in tests_require should also be listed in : # requirements.txt so that dependencies aren't downloaded at test-time : # (when it's more difficult to override various pip installation options). Does this also apply to setuptools_scm and unittest2? http://gerrit.cloudera.org:8080/#/c/11146/1/python/setup.py@202 PS1, Line 202: cython >= 0.21' Not related to this CR, but is it important that this doesn't match up with requirements.txt (cython ==0.26.1)? -- To view, visit http://gerrit.cloudera.org:8080/11146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadb42535956461fbcb41adc67f5e4c73c310463d Gerrit-Change-Number: 11146 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 07 Aug 2018 18:17:51 +0000 Gerrit-HasComments: Yes
