Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11146 )
Change subject: python: copy pandas dependency into requirements.txt ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11146/1/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/11146/1/python/setup.py@193 PS1, Line 193: Note: dependencies in tests_require should also be listed in : # requirements.txt so that dependencies aren't downloaded at test-time : # (when it's more difficult to override various pip installation options). > Does this also apply to setuptools_scm and unittest2? I don't know that the opposite of this statement (i.e. that things in requirements.txt should be in tests_require or install_requires) is necessarily true. I've left it alone since I don't fully understand it. http://gerrit.cloudera.org:8080/#/c/11146/1/python/setup.py@202 PS1, Line 202: cython >= 0.21' > Not related to this CR, but is it important that this doesn't match up with Not really, since we guarantee installing Cythin via requirements.txt before this. I guess it could have an impact on deployed systems (i.e. if you run 'pip install kudu-python', pip will satisfy the contents of install_requires first), but I don't know if it really matters or not. -- To view, visit http://gerrit.cloudera.org:8080/11146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadb42535956461fbcb41adc67f5e4c73c310463d Gerrit-Change-Number: 11146 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 07 Aug 2018 22:24:55 +0000 Gerrit-HasComments: Yes
