Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11146 )
Change subject: python: copy pandas dependency into requirements.txt ...................................................................... Patch Set 2: Ok by me. I think the right approach here would be to remove the test requirement from setup.py and add back in the skip test logic + the install of pandas in the jenkins script. This was the original approach but was objected to, but in light of this i think it makes sense to go with the original approach. -- To view, visit http://gerrit.cloudera.org:8080/11146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadb42535956461fbcb41adc67f5e4c73c310463d Gerrit-Change-Number: 11146 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 08 Aug 2018 04:20:06 +0000 Gerrit-HasComments: No
