Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 )
Change subject: [location_awareness] Add 'location' column in tserver list ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/kudu-tool-test.cc@2058 PS1, Line 2058: NO_FATALS(StartExternalMiniCluster(opts)); > Yeah, we need to either make this a separate test where the flag is set bef Maybe I'm wrong. I feel like StartExternalMiniCluster(opts) is the only method where we can reset the flags. But we can't have this method called twice in a test. So I'm thinking of making two separate tests: TestTserverListLocation, and TestTserverListLocationNone. Does that sound right? http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/kudu-tool-test.cc@2066 PS1, Line 2066: > Is it important to have this spacing to be some specified length? If not, I was thinking ASSERT_STR_CONTAINS would overlook cases where there's garbage string or extra rows. But yeah maybe ASSERT_STR_CONTAINS should be good enough. -- To view, visit http://gerrit.cloudera.org:8080/11313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6c9dc8bd08b8d907111fac850fc6fd2c2b96fb8 Gerrit-Change-Number: 11313 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 24 Aug 2018 20:02:32 +0000 Gerrit-HasComments: Yes
