Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11313 )

Change subject: [location_awareness] Add 'location' column in tserver list
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11313/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11313/3//COMMIT_MSG@20
PS3, Line 20: not assgined
<none>


http://gerrit.cloudera.org:8080/#/c/11313/3/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/11313/3/src/kudu/master/master_service.cc@419
PS3, Line 419: entry->set_location
I think it's better to not set this field at all if location in the descriptor 
is not set:

if (desc->location()) {
  entry->set_location(...);
}



--
To view, visit http://gerrit.cloudera.org:8080/11313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6c9dc8bd08b8d907111fac850fc6fd2c2b96fb8
Gerrit-Change-Number: 11313
Gerrit-PatchSet: 3
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Tue, 28 Aug 2018 21:07:28 +0000
Gerrit-HasComments: Yes

Reply via email to