Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 )
Change subject: [location_awareness] Add 'location' column in tserver list ...................................................................... Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/11313/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11313/1//COMMIT_MSG@16 PS1, Line 16: <none> > I'd prefer a value like <none>. There's a couple of advantages to it: Done http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/common/wire_protocol.proto File src/kudu/common/wire_protocol.proto: http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/common/wire_protocol.proto@84 PS1, Line 84: > ServerRegistrationPB is also used for both master and tservers. Done http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/common/wire_protocol.proto@84 PS1, Line 84: > I think NodeInstancePB is about any kudu server, i.e. masters are also mean Done http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/master/ts_descriptor.cc@310 PS1, Line 310: } : > I agree we should leave the field unset if there's no location. For one thi Done http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/kudu-tool-test.cc@2038 PS1, Line 2038: _F (ToolTest, TestTserverL > nit: drop the parentheses. Done http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/kudu-tool-test.cc@2038 PS1, Line 2038: _F (ToolTest, TestTserverL > Also, comments end in a period. Done http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/kudu-tool-test.cc@2047 PS1, Line 2047: > Consider using ASSERT_STR_CONTAINS macro. Or the spacing is really importa Done http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/kudu-tool-test.cc@2050 PS1, Line 2050: ring out; > nit: drop the parentheses. Done http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/kudu-tool-test.cc@2050 PS1, Line 2050: ring out; > Ditto period. Done http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/kudu-tool-test.cc@2054 PS1, Line 2054: ASSERT_STR_CONTAINS(out, cluster_->tablet_server(0)->uuid() + "," + location); > Why is it important to set FLAGS_location_mapping_cmd if it's an external c Done http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/kudu-tool-test.cc@2058 PS1, Line 2058: _FATALS(StartExternalMiniCluster()); > The minicluster object itself should have methods to stop it, and then I th Done http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/kudu-tool-test.cc@2066 PS1, Line 2066: S(out, c > I think using --columns=uuid,location with --format=csv and then testing AS Done http://gerrit.cloudera.org:8080/#/c/11313/1/src/kudu/tools/testdata/first_argument.sh File src/kudu/tools/testdata/first_argument.sh: PS1: > You'll need to add this as a data file in the CMakeLists. See my patch to a Done -- To view, visit http://gerrit.cloudera.org:8080/11313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6c9dc8bd08b8d907111fac850fc6fd2c2b96fb8 Gerrit-Change-Number: 11313 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Mon, 27 Aug 2018 23:09:20 +0000 Gerrit-HasComments: Yes
