Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11958 )
Change subject: [tools] ksck: Add information about replica counts to plain ksck output ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11958/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11958/1//COMMIT_MSG@11 PS1, Line 11: it outputs a 5-number summary of the distribution of : replicas and lists any outliers > Maybe your answer to this lies in what you've implemented, but do you think Yeah, why not? It's the verbose output. http://gerrit.cloudera.org:8080/#/c/11958/1//COMMIT_MSG@26 PS1, Line 26: Small > Hrm, I might've missed this. What is this referring to? Also, how are you q It should be pretty clear what it means, I think. The reason I even include it is thatthe table will be sorted Small before Big and then within Small sorted by most to least replicas and within Big by least to most, so having the Small/Big label helps make the order understandable. http://gerrit.cloudera.org:8080/#/c/11958/1//COMMIT_MSG@28 PS1, Line 28: In PLAIN_FULL mode it outputs the replica count for every tablet server: : : Tablet Replica Count by Tablet Server : UUID | Host | Replica Count : ----------------------------------+--------------------------------+--------------- : 09d6bf7a02124145b43f43cb7a667b3d | vc1314.halxg.cloudera.com:7050 | 100 : 23d473f441674d43807fd9e631862bfd | vc1308.halxg.cloudera.com:7050 | 100 : 2fb5cdac22b0418bb2df456906e42eb4 | vc1306.halxg.cloudera.com:7050 | 101 : 70f7ee61ead54b1885d819f354eb3405 | vc1316.halxg.cloudera.com:7050 | 95 : 72fcec63e96f4248ae39d114eb3cd7c9 | vc1318.halxg.cloudera.com:7050 | 94 : 86708813b37a44bd8e92c711211c8685 | vc1310.halxg.cloudera.com:7050 | 96 : a662440710624c02bd5612df32cb0235 | vc1302.halxg.cloudera.com:7050 | 101 : c9633273962a4521a32d5e177a118a84 | vc1312.halxg.cloudera.com:7050 | 101 : cc32936bc8594948a04fd4240da36aed | vc1304.halxg.cloudera.com:7050 | 76 : : I also tested it against an empty cluster. > Did you test it with the -tables, -tablets configurations? From the impleme Yes. Actually this output comes from using the -tables. http://gerrit.cloudera.org:8080/#/c/11958/1/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: http://gerrit.cloudera.org:8080/#/c/11958/1/src/kudu/tools/ksck_results.cc@576 PS1, Line 576: tservers_sorted_by_replica_count.emplace_back(entry.first, > warning: 'emplace_back' is called inside a loop; consider pre-allocating th Done -- To view, visit http://gerrit.cloudera.org:8080/11958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e5373033ab84c1e34f9519eb9bd4e04a652c595 Gerrit-Change-Number: 11958 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <mbarn...@cloudera.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 20 Nov 2018 07:22:46 +0000 Gerrit-HasComments: Yes
