Hello Fengling Wang, Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett,
I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11958 to look at the new patch set (#4). Change subject: [tools] ksck: Add information about replica counts to plain ksck output ...................................................................... [tools] ksck: Add information about replica counts to plain ksck output This adds some information about replica counts on tablet servers to the output of ksck when ksck is in PLAIN_* mode (i.e. not JSON output). It outputs a 5-number summary of the distribution of replicas and lists any outliers: Tablet Replica Count Summary Statistic | Replica Count ----------------+--------------- Minimum | 1646 First Quartile | 3672 Median | 4075 Third Quartile | 4242 Maximum | 4600 Tablet Replica Count Outliers Type | UUID | Host | Replica Count -------+----------------------------------+--------------------------------+--------------- Small | cc32936bc8594948a04fd4240da36aed | vc1304.halxg.cloudera.com:7050 | 1646 In PLAIN_FULL mode it additionally outputs the replica count for every tablet server: Tablet Replica Count by Tablet Server UUID | Host | Replica Count ----------------------------------+--------------------------------+--------------- 09d6bf7a02124145b43f43cb7a667b3d | vc1314.halxg.cloudera.com:7050 | 100 23d473f441674d43807fd9e631862bfd | vc1308.halxg.cloudera.com:7050 | 100 2fb5cdac22b0418bb2df456906e42eb4 | vc1306.halxg.cloudera.com:7050 | 101 70f7ee61ead54b1885d819f354eb3405 | vc1316.halxg.cloudera.com:7050 | 95 72fcec63e96f4248ae39d114eb3cd7c9 | vc1318.halxg.cloudera.com:7050 | 94 86708813b37a44bd8e92c711211c8685 | vc1310.halxg.cloudera.com:7050 | 96 a662440710624c02bd5612df32cb0235 | vc1302.halxg.cloudera.com:7050 | 101 c9633273962a4521a32d5e177a118a84 | vc1312.halxg.cloudera.com:7050 | 101 cc32936bc8594948a04fd4240da36aed | vc1304.halxg.cloudera.com:7050 | 76 I also tested it against an empty cluster. There's no unit tests added, just because our current testing setup for ksck makes it really painful to add one for this, and it seemed easy enough to check out manually. Probably, a follow up should straighten out ksck-test to make testing ksck changes easier. Change-Id: I7e5373033ab84c1e34f9519eb9bd4e04a652c595 --- M src/kudu/tools/ksck_results.cc M src/kudu/tools/ksck_results.h 2 files changed, 131 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/11958/4 -- To view, visit http://gerrit.cloudera.org:8080/11958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7e5373033ab84c1e34f9519eb9bd4e04a652c595 Gerrit-Change-Number: 11958 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <mbarn...@cloudera.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>