Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11958 )
Change subject: [tools] ksck: Add information about replica counts to plain ksck output ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11958/3/src/kudu/tools/ksck_results.h File src/kudu/tools/ksck_results.h: http://gerrit.cloudera.org:8080/#/c/11958/3/src/kudu/tools/ksck_results.h@358 PS3, Line 358: in the latter (default) : // case, only a quartile summary of the counts will be printed. nit: maybe generalize this to just mention that it prints a summary of the replica counts, since the quartiles are somewhat an implementation detail, and this also doesn't mention outliers. Also the fact that PLAIN_CONCISE is the default probably doesn't need to be here (and maybe shouldn't, in case that changes?) -- To view, visit http://gerrit.cloudera.org:8080/11958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e5373033ab84c1e34f9519eb9bd4e04a652c595 Gerrit-Change-Number: 11958 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <mbarn...@cloudera.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 20 Nov 2018 07:44:13 +0000 Gerrit-HasComments: Yes
