Hello Adar Dembo, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12109
to review the following change.
Change subject: tablet: add support for diff scan iterator
......................................................................
tablet: add support for diff scan iterator
This commit adds plumbing to support creating an iterator at the Tablet
level that supports snap_to_exclude. This includes:
- The Schema helper functions should allow virtual columns. The approach
taken is to "fake" the column id by setting the column id for the
virtual column to one greater than the highest observed column id in
the projection. TODO: is this safe?
- Added a test that validates that ghost rows are returned. This test
should be updated once KUDU-2645 has been implemented, which will
de-duplicate such ghost rows.
Change-Id: I9aa0ce2276bdd37688e7a91a2efcf49a8f802eb5
---
M src/kudu/common/schema.cc
M src/kudu/tablet/CMakeLists.txt
A src/kudu/tablet/diff_scan-test.cc
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tserver/tablet_service.cc
11 files changed, 206 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/12109/1
--
To view, visit http://gerrit.cloudera.org:8080/12109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9aa0ce2276bdd37688e7a91a2efcf49a8f802eb5
Gerrit-Change-Number: 12109
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
