Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12109 )
Change subject: tablet: add support for diff scan iterator ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12109/1/src/kudu/tablet/tablet-test-util.h File src/kudu/tablet/tablet-test-util.h: http://gerrit.cloudera.org:8080/#/c/12109/1/src/kudu/tablet/tablet-test-util.h@244 PS1, Line 244: gscoped_ptr<RowwiseIterator> iter; > warning: use nullptr [modernize-use-nullptr] I went a little farther than I'd prefer making clang-tidy happy with this file, but it finally stopped complaining. -- To view, visit http://gerrit.cloudera.org:8080/12109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9aa0ce2276bdd37688e7a91a2efcf49a8f802eb5 Gerrit-Change-Number: 12109 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 20 Dec 2018 07:58:44 +0000 Gerrit-HasComments: Yes
