Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12109 )
Change subject: tablet: add support for diff scan iterator ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12109/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/12109/3/src/kudu/tablet/tablet.cc@408 PS3, Line 408: opts.order = UNORDERED; You can omit this; it's the default value. http://gerrit.cloudera.org:8080/#/c/12109/3/src/kudu/tablet/tablet_bootstrap-test.cc File src/kudu/tablet/tablet_bootstrap-test.cc: http://gerrit.cloudera.org:8080/#/c/12109/3/src/kudu/tablet/tablet_bootstrap-test.cc@209 PS3, Line 209: opts.snap_to_include = MvccSnapshot::CreateSnapshotIncludingAllTransactions(); You can omit this; it's the default value. -- To view, visit http://gerrit.cloudera.org:8080/12109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9aa0ce2276bdd37688e7a91a2efcf49a8f802eb5 Gerrit-Change-Number: 12109 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 21 Dec 2018 19:26:22 +0000 Gerrit-HasComments: Yes
