Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12274 )
Change subject: Fix master_sentry-itest built in RELEASE mode ...................................................................... Patch Set 1: (1 comment) > (1 comment) > > The changes to sentry_authz_provider and the thrift file seem > unrelated. It is necessary to not break macOS build. http://gerrit.cloudera.org:8080/#/c/12274/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/12274/1/src/kudu/master/catalog_manager.cc@747 PS1, Line 747: authz_provider_.reset(new master::SentryAuthzProvider()); > Shouldn't this be conditioned on some Sentry gflag? Or is that conditioning Right, the constructor of SentryAuthzProvider isn't doing anything. -- To view, visit http://gerrit.cloudera.org:8080/12274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e90b2dc5372c87b78d381f04780f6b5db60271c Gerrit-Change-Number: 12274 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 25 Jan 2019 05:23:34 +0000 Gerrit-HasComments: Yes
