Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12274 )
Change subject: Fix master_sentry-itest built in RELEASE mode ...................................................................... Patch Set 1: (1 comment) > (1 comment) > > > It is necessary to not break macOS build. > > So the macOS build is already broken? Or is it somehow broken from > this change? > > If the latter, I don't understand why; we've been building > sentry_authz_provider.cc on macOS for some time. It is the latter, after I add a to SentryAuthzProvider in CatalogManager, > (1 comment) > > > It is necessary to not break macOS build. > > So the macOS build is already broken? Or is it somehow broken from > this change? > > If the latter, I don't understand why; we've been building > sentry_authz_provider.cc on macOS for some time. Right, once I added the call to SentryAuthzProvider in CatalogManager, the compilation on macOS failed with: In file included from /Users/hao.hao/Documents/git-repos/kudu/src/kudu/master/catalog_manager.cc:100: In file included from /Users/hao.hao/Documents/git-repos/kudu/src/kudu/master/sentry_authz_provider.h:24: In file included from /Users/hao.hao/Documents/git-repos/kudu/src/kudu/sentry/sentry_client.h:23: In file included from /Users/hao.hao/Documents/git-repos/kudu/build/debug/src/kudu/sentry/SentryPolicyService.h:12: /Users/hao.hao/Documents/git-repos/kudu/build/debug/src/kudu/sentry/sentry_policy_service_types.h:26:5: error: expected identifier TRUE = 1, ^ /usr/include/mach/boolean.h:81:14: note: expanded from macro 'TRUE' #define TRUE 1 http://gerrit.cloudera.org:8080/#/c/12274/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/12274/1/src/kudu/master/catalog_manager.cc@747 PS1, Line 747: authz_provider_.reset(new master::SentryAuthzProvider()); > I thought when the full Sentry integration is merged, Start/Stop will be ca Sure, I can change to that. -- To view, visit http://gerrit.cloudera.org:8080/12274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e90b2dc5372c87b78d381f04780f6b5db60271c Gerrit-Change-Number: 12274 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 25 Jan 2019 06:24:23 +0000 Gerrit-HasComments: Yes