Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12274 )
Change subject: Fix master_sentry-itest built in RELEASE mode ...................................................................... Fix master_sentry-itest built in RELEASE mode Commit 9098f442e introduced a dummy integration test to ensure mini cluster can start with both mini sentry and mini hms. However, this test fails with 'unknown command line flag' error in RELEASE mode. Since RELEASE builds are statically linked, the linker drops the symbols defined by 'sentry_authz_provider.cc', considering they're not needed. Because there is no static call path from the master into any function in 'sentry_authz_provider.cc'. This test passed upstream pre-commit check because we force dynamic linkage in all dist-test runs, even for RELEASE builds. This patch fixes it by adding such call path explicitly. A proper integration with SentryAuthzProvider in the master will be landed in a follow-up. master_sentry-itest built in RELEASE mode passed locally after the change. Change-Id: I4e90b2dc5372c87b78d381f04780f6b5db60271c Reviewed-on: http://gerrit.cloudera.org:8080/12274 Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Kudu Jenkins --- M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/sentry_authz_provider-test.cc M src/kudu/master/sentry_authz_provider.cc M src/kudu/master/sentry_authz_provider.h M src/kudu/sentry/sentry_policy_service.thrift 6 files changed, 40 insertions(+), 16 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4e90b2dc5372c87b78d381f04780f6b5db60271c Gerrit-Change-Number: 12274 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120)