Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12715 )
Change subject: [java] Make the KuduScanner iterable ...................................................................... Patch Set 1: Code-Review-1 I seem to remember we considered this several years ago and rejected it due to some object reuse optimizations -- for example RowResultIterator actually yields the same RowResult object repeatedly, and just advances it. This makes it unsafe to use as a general iterator -- eg new ArrayList<>(myScanner) would end up with an array cotaining a bunch of copies of the same row, rather than the expected results. If you look at the RowResult class it actually says it's not safe to store. Did I miss somewhere where this patch handles this? -- To view, visit http://gerrit.cloudera.org:8080/12715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e4ac59e30d0562c0a381d5e304af1dcfdcf5a1a Gerrit-Change-Number: 12715 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 11 Mar 2019 16:40:48 +0000 Gerrit-HasComments: No
