Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12715 )
Change subject: [java] Make the KuduScanner iterable ...................................................................... Patch Set 1: Perhaps we could change the default behavior to actually copy RowResults rather than reusing them. I'm not sure the reuse optimization is really such a huge win in modern JVMs which can probably escape-analysis optimize it away... we can add a flag to reuse for advanced users, since I think even without an iterator API people probably make the mistake of shoving RowResults in a list. Probably better to be foot-gun-proof than avoiding a optimization. -- To view, visit http://gerrit.cloudera.org:8080/12715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e4ac59e30d0562c0a381d5e304af1dcfdcf5a1a Gerrit-Change-Number: 12715 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 11 Mar 2019 16:49:24 +0000 Gerrit-HasComments: No
