Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12715 )
Change subject: [java] Make the KuduScanner iterable ...................................................................... Patch Set 1: > Patch Set 1: > > The more I think about this, the more I still think it is useful. > > I assume the optimization is to prevent having 1 object per row result, so > sharing the actual data isn't enough. If 1 object pre row isn't a problem > this could be fixed. Yea, that's my suggestion above. Create one object per row, and make sure that "next batch" also gets a new buffer (I think it already does?). Let's make the default behavior "safe". There's still a potential foot-gun in terms of memory blowup that each RowResult holds a reference to the whole batch of results, but I think that one's a little less likely to cause problems, and we could offer a 'RowResult.detachMemoryFromBatch()' or something as a workaround. -- To view, visit http://gerrit.cloudera.org:8080/12715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e4ac59e30d0562c0a381d5e304af1dcfdcf5a1a Gerrit-Change-Number: 12715 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 11 Mar 2019 17:25:08 +0000 Gerrit-HasComments: No
