Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12716 )
Change subject: [util] separate generalized CacheMetrics ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12716/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12716/1//COMMIT_MSG@15 PS1, Line 15: These changes are introduced to accommodate a few follow-up : modifications introducing a TTL-based cache. I'm still not convinced that a separate base implementation for the TTL-based cache is better than reusing the one in util/cache.{cc,h}. Can you share more details on what challenges you faced? -- To view, visit http://gerrit.cloudera.org:8080/12716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee18214b57e4e0c86e23c3b2e9cc2ee481812844 Gerrit-Change-Number: 12716 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 11 Mar 2019 19:16:59 +0000 Gerrit-HasComments: Yes
