Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12716 )
Change subject: [util] separate generalized CacheMetrics ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12716/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12716/1//COMMIT_MSG@15 PS1, Line 15: These changes are introduced to accommodate a few follow-up : modifications introducing a TTL-based cache. > Regarding #1, I agree that the implementation has some rough edges, though Thanks -- that makes sense. I especially don't want to keep Kudu master open for DoS-like issues caused by huge Sentry responses. I agree that putting capacity on just number of items is the cache is not enough in that case since I realized there is no limit on the size of Sentry's response. I'll take a closer look at adapting the LRU cache for the master authz cache needs. Thanks for the PosixSequentialFile::memory_footprint() pointer :) -- To view, visit http://gerrit.cloudera.org:8080/12716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee18214b57e4e0c86e23c3b2e9cc2ee481812844 Gerrit-Change-Number: 12716 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 12 Mar 2019 05:27:23 +0000 Gerrit-HasComments: Yes
