Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12716
to look at the new patch set (#2).
Change subject: DO NOT REVIEW [util] separate generalized CacheMetrics
......................................................................
DO NOT REVIEW [util] separate generalized CacheMetrics
Separated the generic counters into CacheMetrics to make it possible
using CacheMetrics for other cache types. The LRUCache now uses
LRUCacheMetrics which has some specifics attributed to LRUCache itself.
Also, the instantiations of metrics counters specific for the block LRU
cache have been moved into BlockCacheMetrics structure.
These changes are introduced to accommodate a few follow-up
modifications introducing a TTL-based cache.
Change-Id: Iee18214b57e4e0c86e23c3b2e9cc2ee481812844
---
M src/kudu/cfile/block_cache.cc
M src/kudu/util/CMakeLists.txt
R src/kudu/util/block_cache_metrics.cc
A src/kudu/util/block_cache_metrics.h
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
M src/kudu/util/cache_metrics.h
M src/kudu/util/file_cache.cc
A src/kudu/util/lru_cache_metrics.h
M src/kudu/util/nvm_cache.cc
11 files changed, 120 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/12716/2
--
To view, visit http://gerrit.cloudera.org:8080/12716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee18214b57e4e0c86e23c3b2e9cc2ee481812844
Gerrit-Change-Number: 12716
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)