Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12825 )
Change subject: WIP [util] introduce TTL cache ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12825/4/src/kudu/util/ttl_cache.h File src/kudu/util/ttl_cache.h: http://gerrit.cloudera.org:8080/#/c/12825/4/src/kudu/util/ttl_cache.h@134 PS4, Line 134: existing entry in the cache, if any. It looks like if there is no expired entries, the cache entry is evicted by FIFO policy? If so, can you please comment here to make the eviction rule more clear? -- To view, visit http://gerrit.cloudera.org:8080/12825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8aa0ebe6b26bf34ca0e02bebbdb6a94f6b00621 Gerrit-Change-Number: 12825 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 28 Mar 2019 17:45:03 +0000 Gerrit-HasComments: Yes
