Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12825 )
Change subject: [util] introduce TTL cache ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/12825/4/src/kudu/util/ttl_cache.h File src/kudu/util/ttl_cache.h: http://gerrit.cloudera.org:8080/#/c/12825/4/src/kudu/util/ttl_cache.h@134 PS4, Line 134: s method returns corresponding handl > Well, this comment was meant to refer to an entry with the same key that's Hmm, that means if entries that haven't expired can be evicted while the one expired may not? If so, do you consider it as an issue? I saw you put a TODO 'add an option to evict expired entries on a periodic timer'. Are you consider that a must-do for using the TTL cache for master authz? -- To view, visit http://gerrit.cloudera.org:8080/12825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8aa0ebe6b26bf34ca0e02bebbdb6a94f6b00621 Gerrit-Change-Number: 12825 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 28 Mar 2019 18:35:07 +0000 Gerrit-HasComments: Yes
