Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12825 )
Change subject: [util] introduce TTL cache ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12825/4/src/kudu/util/ttl_cache.h File src/kudu/util/ttl_cache.h: http://gerrit.cloudera.org:8080/#/c/12825/4/src/kudu/util/ttl_cache.h@134 PS4, Line 134: existing entry in the cache, if any. > Hmm, that means if entries that haven't expired can be evicted while the on I don't quite understand what you mean here. The TTL cache has a static setting for the TTL of its entries, so _all_ added entries have the same TTL. The entries added first always have earliest expiration time. With that, how is it possible to get into a situation when an expired entry is still in the cache, but a non-expired one has been removed already? -- To view, visit http://gerrit.cloudera.org:8080/12825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8aa0ebe6b26bf34ca0e02bebbdb6a94f6b00621 Gerrit-Change-Number: 12825 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 28 Mar 2019 18:44:40 +0000 Gerrit-HasComments: Yes
